Skip to content

fix(no-misused-observables): don't report on static accessor properties #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix(no-misused-observables): don't report on static accessor properties #240

merged 1 commit into from
Jun 26, 2025

Conversation

JasonWeinzierl
Copy link
Owner

See tseslint issue 10814.

Note that due to #66 , we currently wouldn't catch any violations of this rule for non-static accessors, but that should be fixed and tested separately in #66 .

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2025 •
edited
Loading

LCOV of commit 445e1da during .github/workflows/ci.yml #611

Summary coverage rate:
  lines......: 96.7% (4492 of 4646 lines)
  functions..: 96.2% (276 of 287 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  src/etc/is.ts                                                     |36.5%     96| 0.0%    25|    -      0
  src/rules/no-misused-observables.ts                               | 4.0%    451| 0.0%    18|    -      0

@JasonWeinzierl JasonWeinzierl merged commit eee86ce into main Jun 26, 2025
3 checks passed
@JasonWeinzierl JasonWeinzierl deleted the misused-accessor branch June 26, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JasonWeinzierl